-
Notifications
You must be signed in to change notification settings - Fork 208
add /validate endpoint for md dataset
#1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Right now the I have added the If I understand well, when variable is not set, you'll iterate through all the variables and return something like |
|
This approach seems good for short-term use, though eventually it would be nice to use a schema validation approach (e.g., https://github.com/xarray-contrib/xarray-schema) rather than eagerly applying the operations to save time and memory. My main concern is about the validation and io code becoming out of sync. Could one or more utility functions be defined for some of the code in https://github.com/developmentseed/titiler/blob/main/src/titiler/xarray/titiler/xarray/io.py#L96-L202 for use in both io and validate to mitigate that chance? It also looks like the metadata and variable extensions are becoming redundant. Is the separate Variable extension still needed? |
…o feature/xarray-validate
|
updated with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'TiTiler performance Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 1c76de3 | Previous: 38f884d | Ratio |
|---|---|---|---|
WebMercator longest_transaction |
0.07 s |
0.05 s |
1.40 |
This comment was automatically generated by workflow using github-action-benchmark.
@maxrjones I didn't change this part, might do in another PR |

Q:
variablesMy knowledge of Xarray dataset structure is limited so would love some help on this 🙏